-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data checks in client.py #30
Conversation
Can you ping me again when you added the MAX_ROWS and MAX_COLS we mentioned in the meeting? :) |
Yes
…On Thu 4. Jul 2024 at 16:40, Liam, Shi Bin Hoo ***@***.***> wrote:
Can you ping me again when you added the MAX_ROWS and MAX_COLS we
mentioned in the meeting? :)
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFQNBHPLI5Q2627EQWGT2T3ZKVNEXAVCNFSM6AAAAABKLQRE3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBZGE2TAMZQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Please also setup your environment for ruff formatting according to |
Good to go after the slight refactor in test and correcting the format. Thanks!! |
Good to merge now, reformatted accordingly! |
@Sathya98
@SamuelGabriel can you help to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny little change I would request than it is good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Description
Try to be precise. You can additionally add comments to your PR, this might help the reviewer a lot.
Added a function check_training_data that checks the X and y tables for basic integrity and length inconsistencies before sending them over to the tabpfn server
Also added a unit test in test_client.py that tests the function with the breast cancer dataset
If you used new dependencies: Did you add them to
requirements.txt
?Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.
Breaking changes
If you made any breaking changes, please update the version number.
Breaking changes are totally fine, we just need to make sure to keep the users informed and the server in sync.
Does this PR break the API? If so, what is the corresponding server commit?
Does this PR break the user interface? If so, why?
Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.